mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-14 10:00:38 +09:00
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Human operators supervise that work through issue lists, issue detail, comments, inbox groups, markdown references, and profile/activity surfaces > - The branch had many small UI fixes that improve the operator loop but do not need to ship with backend runtime migrations > - These changes belong together as board workflow polish because they affect scanning, navigation, issue context, comment state, and markdown clarity > - This pull request groups the UI-only slice so it can merge independently from runtime/backend changes > - The benefit is a clearer board experience with better issue context, steadier optimistic updates, and more predictable keyboard navigation ## What Changed - Improves issue properties, sub-issue actions, blocker chips, and issue list/detail refresh behavior. - Adds blocker context above the issue composer and stabilizes queued/interrupted comment UI state. - Improves markdown issue/GitHub link rendering and opens external markdown links in a new tab. - Adds inbox group keyboard navigation and fold/unfold support. - Polishes activity/avatar/profile/settings/workspace presentation details. ## Verification - `pnpm exec vitest run ui/src/components/IssueProperties.test.tsx ui/src/components/IssueChatThread.test.tsx ui/src/components/MarkdownBody.test.tsx ui/src/lib/inbox.test.ts ui/src/lib/optimistic-issue-comments.test.ts` ## Risks - Low to medium risk: changes are UI-focused but cover high-traffic issue and inbox surfaces. - This branch intentionally does not include the backend runtime changes from the companion PR; where UI calls newer API filters, unsupported servers should continue to fail visibly through existing API error handling. - Visual screenshots were not captured in this heartbeat; targeted component/helper tests cover the changed behavior. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent runtime, shell/git tool use enabled. Exact hosted model build and context window are not exposed in this Paperclip heartbeat environment. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge
157 lines
4.6 KiB
TypeScript
157 lines
4.6 KiB
TypeScript
type MarkdownNode = {
|
|
type: string;
|
|
value?: string;
|
|
url?: string;
|
|
children?: MarkdownNode[];
|
|
};
|
|
|
|
const BARE_ISSUE_IDENTIFIER_RE = /^[A-Z][A-Z0-9]+-\d+$/i;
|
|
const ISSUE_SCHEME_RE = /^issue:\/\/:?([^?#\s]+)(?:[?#].*)?$/i;
|
|
const ISSUE_REFERENCE_TOKEN_RE = /issue:\/\/:?[^\s<>()]+|https?:\/\/[^\s<>()]+|\b[A-Z][A-Z0-9]+-\d+\b/gi;
|
|
|
|
export function parseIssuePathIdFromPath(pathOrUrl: string | null | undefined): string | null {
|
|
if (!pathOrUrl) return null;
|
|
let pathname = pathOrUrl.trim();
|
|
if (!pathname) return null;
|
|
|
|
if (/^https?:\/\//i.test(pathname)) {
|
|
try {
|
|
const url = new URL(pathname);
|
|
if (url.hostname === "github.com" || url.hostname === "www.github.com") return null;
|
|
pathname = url.pathname;
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
const segments = pathname.split("/").filter(Boolean);
|
|
const issueIndex = segments.findIndex((segment) => segment === "issues");
|
|
if (issueIndex === -1 || issueIndex === segments.length - 1) return null;
|
|
const issuePathId = decodeURIComponent(segments[issueIndex + 1] ?? "");
|
|
if (!issuePathId || issuePathId.startsWith(":")) return null;
|
|
return issuePathId;
|
|
}
|
|
|
|
export function parseIssueReferenceFromHref(href: string | null | undefined) {
|
|
if (!href) return null;
|
|
const trimmed = href.trim();
|
|
const issueSchemeMatch = trimmed.match(ISSUE_SCHEME_RE);
|
|
if (issueSchemeMatch?.[1]) {
|
|
const issuePathId = decodeURIComponent(issueSchemeMatch[1]);
|
|
return {
|
|
issuePathId,
|
|
href: `/issues/${encodeURIComponent(issuePathId)}`,
|
|
};
|
|
}
|
|
|
|
const pathId = parseIssuePathIdFromPath(href);
|
|
if (pathId) {
|
|
return {
|
|
issuePathId: pathId,
|
|
href: `/issues/${encodeURIComponent(pathId)}`,
|
|
};
|
|
}
|
|
|
|
if (!BARE_ISSUE_IDENTIFIER_RE.test(trimmed)) return null;
|
|
const normalized = trimmed.toUpperCase();
|
|
return {
|
|
issuePathId: normalized,
|
|
href: `/issues/${encodeURIComponent(normalized)}`,
|
|
};
|
|
}
|
|
|
|
function splitTrailingPunctuation(token: string) {
|
|
let core = token;
|
|
let trailing = "";
|
|
|
|
while (core.length > 0) {
|
|
const lastChar = core.at(-1);
|
|
if (!lastChar || !/[),.;!?]/.test(lastChar)) break;
|
|
if (lastChar === ")") {
|
|
const openCount = (core.match(/\(/g) ?? []).length;
|
|
const closeCount = (core.match(/\)/g) ?? []).length;
|
|
if (closeCount <= openCount) break;
|
|
}
|
|
trailing = `${lastChar}${trailing}`;
|
|
core = core.slice(0, -1);
|
|
}
|
|
|
|
return { core, trailing };
|
|
}
|
|
|
|
function createIssueLinkNode(value: string, href: string, childType: "text" | "inlineCode" = "text"): MarkdownNode {
|
|
return {
|
|
type: "link",
|
|
url: href,
|
|
children: [{ type: childType, value }],
|
|
};
|
|
}
|
|
|
|
function linkifyIssueReferencesInText(value: string): MarkdownNode[] | null {
|
|
const nodes: MarkdownNode[] = [];
|
|
let cursor = 0;
|
|
let matched = false;
|
|
|
|
for (const match of value.matchAll(ISSUE_REFERENCE_TOKEN_RE)) {
|
|
const raw = match[0];
|
|
if (!raw) continue;
|
|
|
|
const start = match.index ?? 0;
|
|
const end = start + raw.length;
|
|
const { core, trailing } = splitTrailingPunctuation(raw);
|
|
const issueRef = parseIssueReferenceFromHref(core);
|
|
if (!issueRef) continue;
|
|
|
|
matched = true;
|
|
if (start > cursor) {
|
|
nodes.push({ type: "text", value: value.slice(cursor, start) });
|
|
}
|
|
nodes.push(createIssueLinkNode(core, issueRef.href));
|
|
if (trailing) {
|
|
nodes.push({ type: "text", value: trailing });
|
|
}
|
|
cursor = end;
|
|
}
|
|
|
|
if (!matched) return null;
|
|
if (cursor < value.length) {
|
|
nodes.push({ type: "text", value: value.slice(cursor) });
|
|
}
|
|
return nodes;
|
|
}
|
|
|
|
function rewriteMarkdownTree(node: MarkdownNode) {
|
|
if (!Array.isArray(node.children) || node.children.length === 0) return;
|
|
if (node.type === "link" || node.type === "linkReference" || node.type === "code" || node.type === "definition" || node.type === "html") {
|
|
return;
|
|
}
|
|
|
|
const nextChildren: MarkdownNode[] = [];
|
|
for (const child of node.children) {
|
|
if (child.type === "inlineCode" && typeof child.value === "string") {
|
|
const issueRef = parseIssueReferenceFromHref(child.value);
|
|
if (issueRef) {
|
|
nextChildren.push(createIssueLinkNode(child.value, issueRef.href, "inlineCode"));
|
|
continue;
|
|
}
|
|
}
|
|
|
|
if (child.type === "text" && typeof child.value === "string") {
|
|
const linked = linkifyIssueReferencesInText(child.value);
|
|
if (linked) {
|
|
nextChildren.push(...linked);
|
|
continue;
|
|
}
|
|
}
|
|
|
|
rewriteMarkdownTree(child);
|
|
nextChildren.push(child);
|
|
}
|
|
node.children = nextChildren;
|
|
}
|
|
|
|
export function remarkLinkIssueReferences() {
|
|
return (tree: MarkdownNode) => {
|
|
rewriteMarkdownTree(tree);
|
|
};
|
|
}
|