mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-14 18:10:39 +09:00
## Thinking Path > - Paperclip is a control plane for autonomous AI companies, where work must end with a clear disposition rather than ambiguous agent liveness. > - Recovery currently detects stalled or missing-next-step issues, but source issue recovery can become split across child recovery issues, blockers, and comments. > - That makes it harder for operators and agents to see who owns recovery and what exact action is needed on the original issue. > - Source-scoped recovery actions give the original issue a first-class active recovery state with owner, evidence, wake policy, and resolution outcome. > - This pull request adds the recovery-action data model, backend reconciliation and resolution APIs, and board UI indicators/actions. > - The benefit is clearer stalled-work recovery without losing source issue context or relying on comments as the liveness path. ## What Changed - Added the `issue_recovery_actions` schema, shared types/constants/validators, and an idempotent `0084_issue_recovery_actions` migration ordered after current `master` migrations. - Updated stranded/missing-disposition recovery to create source-scoped recovery actions, wake the recovery owner on the source issue, and avoid locking the source issue for recovery-action wakes. - Added API support for reading active recovery actions on issue detail/list surfaces and resolving them with restored, blocked, cancelled, or false-positive outcomes. - Require blocked recovery resolutions to have an unresolved first-class blocker, and removed the UI shortcut that could mark recovery blocked without a blocker selection path. - Surfaced recovery indicators/actions in the issue UI, blocker notices, active run panels, issue rows, and Storybook coverage. - Updated docs and focused tests for recovery semantics, ownership, races, stale comments, and UI behavior. ## Verification - `pnpm exec vitest run server/src/__tests__/issue-recovery-actions.test.ts server/src/__tests__/heartbeat-process-recovery.test.ts ui/src/components/IssueRecoveryActionCard.test.tsx ui/src/components/IssueBlockedNotice.test.tsx ui/src/api/issues.test.ts` — 5 files, 72 tests passed. - `pnpm --filter @paperclipai/shared typecheck` — passed. - `pnpm --filter @paperclipai/db typecheck` — passed, including migration numbering check. - `pnpm --filter @paperclipai/server typecheck` — passed. - `pnpm --filter @paperclipai/ui typecheck` — passed. - Follow-up verification after blocker-resolution guard: `pnpm exec vitest run server/src/__tests__/issue-recovery-actions.test.ts ui/src/components/IssueRecoveryActionCard.test.tsx ui/src/api/issues.test.ts` — 3 files, 27 tests passed. - Follow-up `pnpm --filter @paperclipai/server typecheck` — passed. - Follow-up `pnpm --filter @paperclipai/ui typecheck` — passed. - UI states are available in `ui/storybook/stories/source-issue-recovery.stories.tsx`; screenshot capture helper is `scripts/screenshot-recovery-card.cjs`. ## Risks - Medium: recovery behavior changes from child recovery issue ownership toward source-scoped actions, so operators may see stalled-work state in new places. - Migration risk is mitigated by using the next migration slot after `master` and making the table/constraints/index creation idempotent for anyone who previously applied the old branch-local `0082_dizzy_master_mold` migration. - Existing child recovery issue paths are still guarded for already-created recovery issues, but new source-scoped flows should be watched in CI and Greptile review. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent, tool use enabled for shell, Git, GitHub, and local test execution. Context window not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
170 lines
5.4 KiB
TypeScript
170 lines
5.4 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { act } from "react";
|
|
import { createRoot } from "react-dom/client";
|
|
import type { AnchorHTMLAttributes, ReactElement, ReactNode } from "react";
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import { MemoryRouter } from "react-router-dom";
|
|
import { IssueBlockedNotice } from "./IssueBlockedNotice";
|
|
|
|
vi.mock("@/lib/router", () => ({
|
|
Link: ({ children, to, ...props }: AnchorHTMLAttributes<HTMLAnchorElement> & { to: string }) => (
|
|
<a href={to} {...props}>{children}</a>
|
|
),
|
|
}));
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
let root: ReturnType<typeof createRoot> | null = null;
|
|
let container: HTMLDivElement | null = null;
|
|
|
|
afterEach(() => {
|
|
if (root) {
|
|
act(() => root?.unmount());
|
|
}
|
|
root = null;
|
|
container?.remove();
|
|
container = null;
|
|
});
|
|
|
|
function withProviders(node: ReactNode) {
|
|
const client = new QueryClient({ defaultOptions: { queries: { retry: false, gcTime: 0, staleTime: 0 } } });
|
|
return (
|
|
<MemoryRouter>
|
|
<QueryClientProvider client={client}>{node}</QueryClientProvider>
|
|
</MemoryRouter>
|
|
);
|
|
}
|
|
|
|
function render(element: ReactElement) {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
root = createRoot(container);
|
|
act(() => root?.render(withProviders(element)));
|
|
return container;
|
|
}
|
|
|
|
describe("IssueBlockedNotice", () => {
|
|
it("renders a successful-run next-step notice without requiring blockers", () => {
|
|
const node = render(
|
|
<IssueBlockedNotice
|
|
issueStatus="in_progress"
|
|
blockers={[]}
|
|
agentName="CodexCoder"
|
|
successfulRunHandoff={{
|
|
state: "required",
|
|
required: true,
|
|
sourceRunId: "12345678-aaaa-bbbb-cccc-123456789abc",
|
|
correctiveRunId: null,
|
|
assigneeAgentId: "agent-1",
|
|
detectedProgressSummary: "Updated the plan and left follow-up work.",
|
|
createdAt: "2026-05-01T00:00:00.000Z",
|
|
}}
|
|
/>,
|
|
);
|
|
|
|
expect(node.textContent).toContain("This issue still needs a next step.");
|
|
expect(node.textContent).toContain("Corrective wake queued for CodexCoder");
|
|
expect(node.textContent).toContain("Detected progress: Updated the plan");
|
|
expect(node.textContent).not.toContain("Work on this issue is blocked until");
|
|
expect(node.querySelector('[data-successful-run-handoff="required"]')).not.toBeNull();
|
|
});
|
|
|
|
it("does not render when the issue is done even if a stale handoff state is required", () => {
|
|
const node = render(
|
|
<IssueBlockedNotice
|
|
issueStatus="done"
|
|
blockers={[]}
|
|
agentName="CodexCoder"
|
|
successfulRunHandoff={{
|
|
state: "required",
|
|
required: true,
|
|
sourceRunId: "12345678-aaaa-bbbb-cccc-123456789abc",
|
|
correctiveRunId: null,
|
|
assigneeAgentId: "agent-1",
|
|
detectedProgressSummary: "Updated the plan and left follow-up work.",
|
|
createdAt: "2026-05-01T00:00:00.000Z",
|
|
}}
|
|
/>,
|
|
);
|
|
|
|
expect(node.textContent).toBe("");
|
|
});
|
|
|
|
it("does not render when the issue is cancelled even if blockers remain", () => {
|
|
const node = render(
|
|
<IssueBlockedNotice
|
|
issueStatus="cancelled"
|
|
blockers={[
|
|
{
|
|
id: "blocker-1",
|
|
identifier: "PAP-123",
|
|
title: "Blocker",
|
|
status: "in_progress",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
},
|
|
]}
|
|
/>,
|
|
);
|
|
|
|
expect(node.textContent).toBe("");
|
|
});
|
|
|
|
it("renders a recovery indicator on a blocker chip when the blocker has an active recovery action", () => {
|
|
const node = render(
|
|
<IssueBlockedNotice
|
|
issueStatus="blocked"
|
|
blockers={[
|
|
{
|
|
id: "blocker-1",
|
|
identifier: "PAP-123",
|
|
title: "Build still red",
|
|
status: "in_progress",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
activeRecoveryAction: {
|
|
id: "rec-1",
|
|
companyId: "co-1",
|
|
sourceIssueId: "blocker-1",
|
|
recoveryIssueId: null,
|
|
kind: "missing_disposition",
|
|
status: "active",
|
|
ownerType: "agent",
|
|
ownerAgentId: "agent-cto",
|
|
ownerUserId: null,
|
|
previousOwnerAgentId: null,
|
|
returnOwnerAgentId: null,
|
|
cause: "successful_run_missing_state",
|
|
fingerprint: "fp-1",
|
|
evidence: {},
|
|
nextAction: "choose disposition",
|
|
wakePolicy: { type: "wake_owner" },
|
|
monitorPolicy: null,
|
|
attemptCount: 1,
|
|
maxAttempts: 3,
|
|
timeoutAt: null,
|
|
lastAttemptAt: null,
|
|
outcome: null,
|
|
resolutionNote: null,
|
|
resolvedAt: null,
|
|
createdAt: "2026-05-01T00:00:00.000Z",
|
|
updatedAt: "2026-05-01T00:00:00.000Z",
|
|
},
|
|
},
|
|
]}
|
|
/>,
|
|
);
|
|
|
|
const indicator = node.querySelector(
|
|
'[data-testid="issue-blocked-notice-recovery-indicator"]',
|
|
);
|
|
expect(indicator).not.toBeNull();
|
|
expect(indicator?.getAttribute("data-recovery-state")).toBe("needed");
|
|
expect(indicator?.textContent).toContain("Recovery needed");
|
|
});
|
|
});
|