mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-18 19:50:38 +09:00
778e775c35
## Thinking Path
> - Paperclip orchestrates AI-agent companies and needs secrets handling
to work across local development, hosted operators, and governed agent
execution.
> - The affected subsystem is the company-scoped secrets control plane:
database schema, server services/routes, CLI workflows, and the Secrets
settings UI.
> - The gap was that secrets were local-only and operators could not
manage provider vaults or import existing remote references without
exposing plaintext.
> - This branch adds provider vault configuration plus an AWS Secrets
Manager remote-import path while preserving company boundaries, binding
context, and audit trails.
> - I kept the PR to a single branch PR, removed unrelated
lockfile/package drift, rebased the full branch onto the current
`public-gh/master`, and addressed fresh Greptile findings.
> - The benefit is a reviewable implementation of provider-backed
secrets with focused tests covering provider selection, import
conflicts, deleted secret reuse, rotation guards, and AWS signing
behavior.
## What Changed
- Added provider vault support for company secrets, including provider
config storage, default vault handling, health checks, binding usage,
access events, and remote import preview/commit.
- Added an AWS Secrets Manager provider using SigV4 request signing,
bounded request timeouts, namespace guardrails, cached runtime
credential resolution, and external-reference linking without plaintext
reads.
- Added Secrets UI surfaces for vault management and remote import, plus
CLI/API documentation for setup and operations.
- Stabilized routine webhook secret binding paths and SSH
environment-driver fixture bindings discovered during verification.
- Addressed Greptile and CI findings: no lockfile/package drift,
monotonic migration metadata, disabled-vault default races, soft-deleted
secret hiding/recreate behavior, remove behavior with disabled vaults,
soft-deleted external-reference re-import, non-active rotation guards,
managed-secret soft deletion through PATCH, and per-call AWS SDK
credential client churn.
- Rebased this branch onto `public-gh/master` at `0e1a5828` and
force-pushed with lease to keep this as the single PR for the branch.
## Verification
- `git fetch public-gh master`
- `git rebase public-gh/master`
- `git diff --name-only public-gh/master...HEAD | grep
'^pnpm-lock\.yaml$' || true` confirmed `pnpm-lock.yaml` is not in the PR
diff.
- Confirmed migration ordering: master ends at `0081_optimal_dormammu`;
this PR adds `0082_dry_vision` and
`0083_company_secret_provider_configs`.
- Inspected migrations for repeat safety: new tables/indexes use `IF NOT
EXISTS`; foreign keys are guarded by `DO $$ ... IF NOT EXISTS`; column
additions use `ADD COLUMN IF NOT EXISTS`.
- `pnpm -r typecheck` passed before the Greptile follow-up commits.
- `pnpm test:run` ran the full stable Vitest path before the Greptile
follow-up commits; it completed with 3 timing-related failures under
parallel load: `codex-local-execute.test.ts`,
`cursor-local-execute.test.ts`, and `environment-service.test.ts`.
- `pnpm --filter @paperclipai/server exec vitest run
src/__tests__/codex-local-execute.test.ts
src/__tests__/cursor-local-execute.test.ts
src/__tests__/environment-service.test.ts` passed on targeted rerun
(`24/24`).
- `pnpm build` passed before the Greptile follow-up commits. Vite
reported existing chunk-size/dynamic-import warnings.
- After Greptile follow-up commits: `pnpm --filter @paperclipai/server
exec vitest run src/__tests__/secrets-service.test.ts` passed (`26/26`).
- After Greptile follow-up commits: `pnpm --filter @paperclipai/server
exec vitest run src/__tests__/aws-secrets-manager-provider.test.ts
src/__tests__/secrets-service.test.ts` passed (`39/39`).
- After Greptile follow-up commits: `pnpm --filter @paperclipai/server
typecheck` passed.
- Captured Storybook screenshots from `ui/storybook-static` for visual
review.
- Latest PR checks on `5ca3a5cf`: `policy`, serialized server suites
1/4-4/4, `Canary Dry Run`, `e2e`, `security/snyk`, and `Greptile Review`
pass; aggregate `verify` is still registering the completed child
checks.
- Greptile review loop continued through the latest requested pass; all
Greptile review threads are resolved and the latest `Greptile Review`
check on `5ca3a5cf` passed with 0 comments added.
## Screenshots
Before: the provider-vault and remote-import surfaces did not exist on
`master`; these are after-state screenshots from the Storybook fixtures.
## Risks
- Migration risk: this adds new secret provider tables and extends
existing secret rows. The migrations were checked for monotonic ordering
and idempotent guards, but reviewers should still inspect upgrade
behavior carefully.
- Provider risk: AWS support uses direct SigV4 requests. Automated tests
cover signing, request timeouts, vault-config selection, namespace
guardrails, pending-version archival, sanitized provider errors, and
service-level cleanup paths. A real-vault AWS smoke test remains
deployment validation for an operator with AWS credentials rather than
an unverified merge blocker in this local branch.
- UI risk: the Secrets page and import dialog are large new surfaces;
screenshots are included above for reviewer inspection.
- Verification risk: the full local stable test command hit
parallel-load timing failures, although the exact failed files passed
when rerun directly.
- Operational risk: remote import intentionally avoids plaintext reads;
operators must understand that imported external references resolve at
runtime and may fail if AWS permissions change.
> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.
## Model Used
- OpenAI Codex, GPT-5 coding agent with local shell/tool use in the
Paperclip worktree. Exact context-window size was not exposed by the
runtime.
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [ ] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
594 lines
12 KiB
JSON
594 lines
12 KiB
JSON
{
|
|
"version": "7",
|
|
"dialect": "postgresql",
|
|
"entries": [
|
|
{
|
|
"idx": 0,
|
|
"version": "7",
|
|
"when": 1771300567463,
|
|
"tag": "0000_mature_masked_marvel",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 1,
|
|
"version": "7",
|
|
"when": 1771349039633,
|
|
"tag": "0001_fast_northstar",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 2,
|
|
"version": "7",
|
|
"when": 1771349403162,
|
|
"tag": "0002_big_zaladane",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 3,
|
|
"version": "7",
|
|
"when": 1771456737635,
|
|
"tag": "0003_shallow_quentin_quire",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 4,
|
|
"version": "7",
|
|
"when": 1771545600000,
|
|
"tag": "0004_issue_identifiers",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 5,
|
|
"version": "7",
|
|
"when": 1771545601000,
|
|
"tag": "0005_chief_luke_cage",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 6,
|
|
"version": "7",
|
|
"when": 1771545602000,
|
|
"tag": "0006_overjoyed_mister_sinister",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 7,
|
|
"version": "7",
|
|
"when": 1771545603000,
|
|
"tag": "0007_new_quentin_quire",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 8,
|
|
"version": "7",
|
|
"when": 1771534160426,
|
|
"tag": "0008_amused_zzzax",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 9,
|
|
"version": "7",
|
|
"when": 1771534211029,
|
|
"tag": "0009_fast_jackal",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 10,
|
|
"version": "7",
|
|
"when": 1771605173513,
|
|
"tag": "0010_stale_justin_hammer",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 11,
|
|
"version": "7",
|
|
"when": 1771616419708,
|
|
"tag": "0011_windy_corsair",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 12,
|
|
"version": "7",
|
|
"when": 1771619674673,
|
|
"tag": "0012_perpetual_ser_duncan",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 13,
|
|
"version": "7",
|
|
"when": 1771623691139,
|
|
"tag": "0013_dashing_wasp",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 14,
|
|
"version": "7",
|
|
"when": 1771691806349,
|
|
"tag": "0014_many_mikhail_rasputin",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 15,
|
|
"version": "7",
|
|
"when": 1771865100000,
|
|
"tag": "0015_project_color_archived",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 16,
|
|
"version": "7",
|
|
"when": 1771955900000,
|
|
"tag": "0016_agent_icon",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 17,
|
|
"version": "7",
|
|
"when": 1771883888199,
|
|
"tag": "0017_tiresome_gabe_jones",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 18,
|
|
"version": "7",
|
|
"when": 1771897769629,
|
|
"tag": "0018_flat_sleepwalker",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 19,
|
|
"version": "7",
|
|
"when": 1772029333401,
|
|
"tag": "0019_public_victor_mancha",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 20,
|
|
"version": "7",
|
|
"when": 1772032176413,
|
|
"tag": "0020_white_anita_blake",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 21,
|
|
"version": "7",
|
|
"when": 1772122471656,
|
|
"tag": "0021_chief_vindicator",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 22,
|
|
"version": "7",
|
|
"when": 1772186400000,
|
|
"tag": "0022_company_brand_color",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 23,
|
|
"version": "7",
|
|
"when": 1772139727599,
|
|
"tag": "0023_fair_lethal_legion",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 24,
|
|
"version": "7",
|
|
"when": 1772806603601,
|
|
"tag": "0024_far_beast",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 25,
|
|
"version": "7",
|
|
"when": 1772807461603,
|
|
"tag": "0025_nasty_salo",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 26,
|
|
"version": "7",
|
|
"when": 1773089625430,
|
|
"tag": "0026_lying_pete_wisdom",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 27,
|
|
"version": "7",
|
|
"when": 1773150731736,
|
|
"tag": "0027_tranquil_tenebrous",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 28,
|
|
"version": "7",
|
|
"when": 1773432085646,
|
|
"tag": "0028_harsh_goliath",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 29,
|
|
"version": "7",
|
|
"when": 1773417600000,
|
|
"tag": "0029_plugin_tables",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 30,
|
|
"version": "7",
|
|
"when": 1773670925214,
|
|
"tag": "0030_rich_magneto",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 31,
|
|
"version": "7",
|
|
"when": 1773511922713,
|
|
"tag": "0031_zippy_magma",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 32,
|
|
"version": "7",
|
|
"when": 1773542934499,
|
|
"tag": "0032_pretty_doctor_octopus",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 33,
|
|
"version": "7",
|
|
"when": 1773664961967,
|
|
"tag": "0033_shiny_black_tarantula",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 34,
|
|
"version": "7",
|
|
"when": 1773697572188,
|
|
"tag": "0034_fat_dormammu",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 35,
|
|
"version": "7",
|
|
"when": 1773698696169,
|
|
"tag": "0035_marvelous_satana",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 36,
|
|
"version": "7",
|
|
"when": 1773756213455,
|
|
"tag": "0036_cheerful_nitro",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 37,
|
|
"version": "7",
|
|
"when": 1773756922363,
|
|
"tag": "0037_friendly_eddie_brock",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 38,
|
|
"version": "7",
|
|
"when": 1773931592563,
|
|
"tag": "0038_careless_iron_monger",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 39,
|
|
"version": "7",
|
|
"when": 1773926116580,
|
|
"tag": "0039_fat_magneto",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 40,
|
|
"version": "7",
|
|
"when": 1773927102783,
|
|
"tag": "0040_eager_shotgun",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 41,
|
|
"version": "7",
|
|
"when": 1774011294562,
|
|
"tag": "0041_curly_maria_hill",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 42,
|
|
"version": "7",
|
|
"when": 1774031825634,
|
|
"tag": "0042_spotty_the_renegades",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 43,
|
|
"version": "7",
|
|
"when": 1774008910991,
|
|
"tag": "0043_reflective_captain_universe",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 44,
|
|
"version": "7",
|
|
"when": 1774269579794,
|
|
"tag": "0044_illegal_toad",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 45,
|
|
"version": "7",
|
|
"when": 1774530504348,
|
|
"tag": "0045_workable_shockwave",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 46,
|
|
"version": "7",
|
|
"when": 1774960197878,
|
|
"tag": "0046_smooth_sentinels",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 47,
|
|
"version": "7",
|
|
"when": 1775137972687,
|
|
"tag": "0047_overjoyed_groot",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 48,
|
|
"version": "7",
|
|
"when": 1775145655557,
|
|
"tag": "0048_flashy_marrow",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 49,
|
|
"version": "7",
|
|
"when": 1775349863293,
|
|
"tag": "0049_flawless_abomination",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 50,
|
|
"version": "7",
|
|
"when": 1775487782768,
|
|
"tag": "0050_stiff_luckman",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 51,
|
|
"version": "7",
|
|
"when": 1775524651831,
|
|
"tag": "0051_young_korg",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 52,
|
|
"version": "7",
|
|
"when": 1775571715162,
|
|
"tag": "0052_mushy_trauma",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 53,
|
|
"version": "7",
|
|
"when": 1775604018515,
|
|
"tag": "0053_sharp_wild_child",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 54,
|
|
"version": "7",
|
|
"when": 1775750400000,
|
|
"tag": "0054_draft_routines",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 55,
|
|
"version": "7",
|
|
"when": 1775825256196,
|
|
"tag": "0055_kind_weapon_omega",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 56,
|
|
"version": "7",
|
|
"when": 1776084034244,
|
|
"tag": "0056_spooky_ultragirl",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 57,
|
|
"version": "7",
|
|
"when": 1776309613598,
|
|
"tag": "0057_tidy_join_requests",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 58,
|
|
"version": "7",
|
|
"when": 1776542245004,
|
|
"tag": "0058_wealthy_starbolt",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 59,
|
|
"version": "7",
|
|
"when": 1776542246000,
|
|
"tag": "0059_plugin_database_namespaces",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 60,
|
|
"version": "7",
|
|
"when": 1776717606743,
|
|
"tag": "0060_orange_annihilus",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 61,
|
|
"version": "7",
|
|
"when": 1776785165389,
|
|
"tag": "0061_lively_thor_girl",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 62,
|
|
"version": "7",
|
|
"when": 1776780000000,
|
|
"tag": "0062_routine_run_dispatch_fingerprint",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 63,
|
|
"version": "7",
|
|
"when": 1776780001000,
|
|
"tag": "0063_issue_thread_interactions",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 64,
|
|
"version": "7",
|
|
"when": 1776780002000,
|
|
"tag": "0064_issue_thread_interaction_idempotency",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 65,
|
|
"version": "7",
|
|
"when": 1776903900000,
|
|
"tag": "0065_environments",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 66,
|
|
"version": "7",
|
|
"when": 1776903901000,
|
|
"tag": "0066_issue_tree_holds",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 67,
|
|
"version": "7",
|
|
"when": 1776904200000,
|
|
"tag": "0067_agent_default_environment",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 68,
|
|
"version": "7",
|
|
"when": 1776959400000,
|
|
"tag": "0068_environment_local_driver_unique",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 69,
|
|
"version": "7",
|
|
"when": 1776780003000,
|
|
"tag": "0069_liveness_recovery_dedupe",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 70,
|
|
"version": "7",
|
|
"when": 1776780004000,
|
|
"tag": "0070_active_run_output_watchdog",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 71,
|
|
"version": "7",
|
|
"when": 1777131234000,
|
|
"tag": "0071_default_hire_approval_off",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 72,
|
|
"version": "7",
|
|
"when": 1777305216238,
|
|
"tag": "0072_large_sandman",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 73,
|
|
"version": "7",
|
|
"when": 1777382021347,
|
|
"tag": "0073_shiny_salo",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 74,
|
|
"version": "7",
|
|
"when": 1777384535070,
|
|
"tag": "0074_striped_genesis",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 75,
|
|
"version": "7",
|
|
"when": 1777572332006,
|
|
"tag": "0075_cultured_sebastian_shaw",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 76,
|
|
"version": "7",
|
|
"when": 1777675301279,
|
|
"tag": "0076_useful_elektra",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 77,
|
|
"version": "7",
|
|
"when": 1777933347806,
|
|
"tag": "0077_unusual_karnak",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 78,
|
|
"version": "7",
|
|
"when": 1778004024976,
|
|
"tag": "0078_white_darwin",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 79,
|
|
"version": "7",
|
|
"when": 1777821410992,
|
|
"tag": "0079_company_search_document_indexes",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 80,
|
|
"version": "7",
|
|
"when": 1777849000000,
|
|
"tag": "0080_company_search_fuzzystrmatch",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 81,
|
|
"version": "7",
|
|
"when": 1778067785040,
|
|
"tag": "0081_optimal_dormammu",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 82,
|
|
"version": "7",
|
|
"when": 1778067785041,
|
|
"tag": "0082_dry_vision",
|
|
"breakpoints": true
|
|
},
|
|
{
|
|
"idx": 83,
|
|
"version": "7",
|
|
"when": 1778074536410,
|
|
"tag": "0083_company_secret_provider_configs",
|
|
"breakpoints": true
|
|
}
|
|
]
|
|
}
|