mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-18 19:50:38 +09:00
705c1b8d81
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies. > - Scheduled routines are the control-plane path for recurring agent work. > - Routines already had dispatch/history, but their runtime environment did not carry routine-owned secret bindings through execution. > - Operators need routine-specific secrets that can override project/agent env without exposing secret values in history, logs, or access events. > - This pull request adds the routine env runtime contract, wires it into execution, and makes the routine UI/history surfaces show safe secret metadata. > - The benefit is that routine executions can use scoped secret refs predictably while preserving company boundaries and auditability. ## What Changed - Added routine env persistence/runtime support, including `routines.env`, `routine_runs.routine_revision_id`, revision snapshots, and idempotent migration `0086_routine_env_runtime_contract`. - Resolved routine env during heartbeat adapter config assembly with precedence `agent < project < routine` and secret access events recorded against the routine consumer. - Added secret binding synchronization for routine create/update/restore flows and guarded cross-company, missing, disabled, and deleted secret cases. - Added a Secrets tab to routine detail, env/secret history diff rendering, and Storybook coverage for the new UI states. - Added server/UI regression tests, including an embedded-Postgres QA path for routine secret execution and restore behavior. - Updated implementation/database docs for routine env and secret-binding behavior. ## Verification - `pnpm install --frozen-lockfile` after rebasing onto `public-gh/master` to refresh workspace links for the newly-added upstream Grok adapter package. - `pnpm exec vitest run server/src/__tests__/heartbeat-project-env.test.ts server/src/__tests__/routines-service.test.ts server/src/__tests__/secrets-service.test.ts server/src/__tests__/qa-routine-secrets-e2e.test.ts ui/src/components/RoutineHistoryTab.test.tsx` passed: 5 files, 92 tests. - `pnpm -r typecheck` passed across the workspace. - `pnpm build` passed. Vite emitted the existing large-chunk/dynamic-import warnings. - UI screenshots were captured locally during QA in `artifacts/pap-9521/` and `artifacts/pap-9522/`; generated screenshots are not committed to avoid adding binary artifacts to the repo. ## Risks - Migration risk is limited by `IF NOT EXISTS` guards for the new columns, FK, and index, and the migration is ordered as `0086` immediately after upstream `0085`. - Runtime behavior changes env precedence for routine executions by adding routine env as the highest-precedence layer; tests cover agent/project/routine precedence. - Secret handling is security-sensitive; tests cover value-free manifests/events/errors, disabled/missing/deleted secrets, and cross-company rejection. - UI history now renders routine env/secret diffs; tests and Storybook stories cover the main rendering paths. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex coding agent based on GPT-5, with shell/tool use and medium reasoning effort. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> |
||
|---|---|---|
| .. | ||
| 0000_snapshot.json | ||
| 0001_snapshot.json | ||
| 0002_snapshot.json | ||
| 0003_snapshot.json | ||
| 0005_snapshot.json | ||
| 0006_snapshot.json | ||
| 0007_snapshot.json | ||
| 0008_snapshot.json | ||
| 0009_snapshot.json | ||
| 0010_snapshot.json | ||
| 0011_snapshot.json | ||
| 0012_snapshot.json | ||
| 0013_snapshot.json | ||
| 0014_snapshot.json | ||
| 0017_snapshot.json | ||
| 0018_snapshot.json | ||
| 0019_snapshot.json | ||
| 0020_snapshot.json | ||
| 0021_snapshot.json | ||
| 0023_snapshot.json | ||
| 0024_snapshot.json | ||
| 0025_snapshot.json | ||
| 0027_snapshot.json | ||
| 0028_snapshot.json | ||
| 0029_snapshot.json | ||
| 0030_snapshot.json | ||
| 0031_snapshot.json | ||
| 0032_snapshot.json | ||
| 0033_snapshot.json | ||
| 0034_snapshot.json | ||
| 0035_snapshot.json | ||
| 0036_snapshot.json | ||
| 0037_snapshot.json | ||
| 0038_snapshot.json | ||
| 0039_snapshot.json | ||
| 0040_snapshot.json | ||
| 0041_snapshot.json | ||
| 0044_snapshot.json | ||
| 0045_snapshot.json | ||
| 0046_snapshot.json | ||
| 0047_snapshot.json | ||
| 0048_snapshot.json | ||
| 0049_snapshot.json | ||
| 0050_snapshot.json | ||
| 0051_snapshot.json | ||
| 0052_snapshot.json | ||
| 0053_snapshot.json | ||
| 0055_snapshot.json | ||
| 0056_snapshot.json | ||
| 0057_snapshot.json | ||
| 0058_snapshot.json | ||
| 0060_snapshot.json | ||
| 0061_snapshot.json | ||
| 0072_snapshot.json | ||
| 0073_snapshot.json | ||
| 0074_snapshot.json | ||
| 0075_snapshot.json | ||
| 0077_snapshot.json | ||
| 0078_snapshot.json | ||
| 0081_snapshot.json | ||
| _journal.json | ||