mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-14 18:10:39 +09:00
## Thinking Path > - Paperclip is a control plane for autonomous AI companies, where work must end with a clear disposition rather than ambiguous agent liveness. > - Recovery currently detects stalled or missing-next-step issues, but source issue recovery can become split across child recovery issues, blockers, and comments. > - That makes it harder for operators and agents to see who owns recovery and what exact action is needed on the original issue. > - Source-scoped recovery actions give the original issue a first-class active recovery state with owner, evidence, wake policy, and resolution outcome. > - This pull request adds the recovery-action data model, backend reconciliation and resolution APIs, and board UI indicators/actions. > - The benefit is clearer stalled-work recovery without losing source issue context or relying on comments as the liveness path. ## What Changed - Added the `issue_recovery_actions` schema, shared types/constants/validators, and an idempotent `0084_issue_recovery_actions` migration ordered after current `master` migrations. - Updated stranded/missing-disposition recovery to create source-scoped recovery actions, wake the recovery owner on the source issue, and avoid locking the source issue for recovery-action wakes. - Added API support for reading active recovery actions on issue detail/list surfaces and resolving them with restored, blocked, cancelled, or false-positive outcomes. - Require blocked recovery resolutions to have an unresolved first-class blocker, and removed the UI shortcut that could mark recovery blocked without a blocker selection path. - Surfaced recovery indicators/actions in the issue UI, blocker notices, active run panels, issue rows, and Storybook coverage. - Updated docs and focused tests for recovery semantics, ownership, races, stale comments, and UI behavior. ## Verification - `pnpm exec vitest run server/src/__tests__/issue-recovery-actions.test.ts server/src/__tests__/heartbeat-process-recovery.test.ts ui/src/components/IssueRecoveryActionCard.test.tsx ui/src/components/IssueBlockedNotice.test.tsx ui/src/api/issues.test.ts` — 5 files, 72 tests passed. - `pnpm --filter @paperclipai/shared typecheck` — passed. - `pnpm --filter @paperclipai/db typecheck` — passed, including migration numbering check. - `pnpm --filter @paperclipai/server typecheck` — passed. - `pnpm --filter @paperclipai/ui typecheck` — passed. - Follow-up verification after blocker-resolution guard: `pnpm exec vitest run server/src/__tests__/issue-recovery-actions.test.ts ui/src/components/IssueRecoveryActionCard.test.tsx ui/src/api/issues.test.ts` — 3 files, 27 tests passed. - Follow-up `pnpm --filter @paperclipai/server typecheck` — passed. - Follow-up `pnpm --filter @paperclipai/ui typecheck` — passed. - UI states are available in `ui/storybook/stories/source-issue-recovery.stories.tsx`; screenshot capture helper is `scripts/screenshot-recovery-card.cjs`. ## Risks - Medium: recovery behavior changes from child recovery issue ownership toward source-scoped actions, so operators may see stalled-work state in new places. - Migration risk is mitigated by using the next migration slot after `master` and making the table/constraints/index creation idempotent for anyone who previously applied the old branch-local `0082_dizzy_master_mold` migration. - Existing child recovery issue paths are still guarded for already-created recovery issues, but new source-scoped flows should be watched in CI and Greptile review. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent, tool use enabled for shell, Git, GitHub, and local test execution. Context window not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
238 lines
8.2 KiB
TypeScript
238 lines
8.2 KiB
TypeScript
import { memo, useMemo } from "react";
|
|
import { Link } from "@/lib/router";
|
|
import { useQueries, useQuery } from "@tanstack/react-query";
|
|
import type { Issue, IssueRecoveryAction } from "@paperclipai/shared";
|
|
import { heartbeatsApi, type LiveRunForIssue } from "../api/heartbeats";
|
|
import type { TranscriptEntry } from "../adapters";
|
|
import { issuesApi } from "../api/issues";
|
|
import { queryKeys } from "../lib/queryKeys";
|
|
import { cn, relativeTime } from "../lib/utils";
|
|
import {
|
|
deriveActiveRecoveryDisplayState,
|
|
RECOVERY_CHIP_DEFAULT_TONE,
|
|
} from "../lib/recovery-display";
|
|
import { ExternalLink } from "lucide-react";
|
|
import { Identity } from "./Identity";
|
|
import { RunChatSurface } from "./RunChatSurface";
|
|
import { useLiveRunTranscripts } from "./transcript/useLiveRunTranscripts";
|
|
|
|
function RunCardRecoveryChip({ action }: { action: IssueRecoveryAction }) {
|
|
const state = deriveActiveRecoveryDisplayState(action);
|
|
if (!state) return null;
|
|
const tone = RECOVERY_CHIP_DEFAULT_TONE[state];
|
|
const Icon = tone.icon;
|
|
return (
|
|
<span
|
|
data-testid="active-agent-run-recovery-indicator"
|
|
data-recovery-state={state}
|
|
role="status"
|
|
aria-label={tone.label}
|
|
title={`${tone.label} — open the source issue to act.`}
|
|
className={cn(
|
|
"inline-flex shrink-0 items-center gap-0.5 rounded-full border px-1.5 py-0.5 text-[10px] font-medium",
|
|
tone.className,
|
|
)}
|
|
>
|
|
<Icon className="h-2.5 w-2.5" aria-hidden />
|
|
{tone.label}
|
|
</span>
|
|
);
|
|
}
|
|
|
|
const MIN_DASHBOARD_RUNS = 4;
|
|
const DASHBOARD_RUN_CARD_LIMIT = 4;
|
|
const DASHBOARD_LOG_POLL_INTERVAL_MS = 15_000;
|
|
const DASHBOARD_LOG_READ_LIMIT_BYTES = 64_000;
|
|
const DASHBOARD_MAX_CHUNKS_PER_RUN = 40;
|
|
const EMPTY_TRANSCRIPT: TranscriptEntry[] = [];
|
|
|
|
function isRunActive(run: LiveRunForIssue): boolean {
|
|
return run.status === "queued" || run.status === "running";
|
|
}
|
|
|
|
interface ActiveAgentsPanelProps {
|
|
companyId: string;
|
|
title?: string;
|
|
minRunCount?: number;
|
|
fetchLimit?: number;
|
|
cardLimit?: number;
|
|
gridClassName?: string;
|
|
cardClassName?: string;
|
|
emptyMessage?: string;
|
|
queryScope?: string;
|
|
showMoreLink?: boolean;
|
|
}
|
|
|
|
export function ActiveAgentsPanel({
|
|
companyId,
|
|
title = "Agents",
|
|
minRunCount = MIN_DASHBOARD_RUNS,
|
|
fetchLimit,
|
|
cardLimit = DASHBOARD_RUN_CARD_LIMIT,
|
|
gridClassName,
|
|
cardClassName,
|
|
emptyMessage = "No recent agent runs.",
|
|
queryScope = "dashboard",
|
|
showMoreLink = true,
|
|
}: ActiveAgentsPanelProps) {
|
|
const { data: liveRuns } = useQuery({
|
|
queryKey: [...queryKeys.liveRuns(companyId), queryScope, { minRunCount, fetchLimit }],
|
|
queryFn: () => heartbeatsApi.liveRunsForCompany(companyId, { minCount: minRunCount, limit: fetchLimit }),
|
|
});
|
|
|
|
const runs = liveRuns ?? [];
|
|
const visibleRuns = useMemo(() => runs.slice(0, cardLimit), [cardLimit, runs]);
|
|
const hiddenRunCount = Math.max(0, runs.length - visibleRuns.length);
|
|
const visibleIssueIds = useMemo(
|
|
() => [...new Set(visibleRuns.map((run) => run.issueId).filter((issueId): issueId is string => Boolean(issueId)))],
|
|
[visibleRuns],
|
|
);
|
|
|
|
const issueQueries = useQueries({
|
|
queries: visibleIssueIds.map((issueId) => ({
|
|
queryKey: queryKeys.issues.detail(issueId),
|
|
queryFn: () => issuesApi.get(issueId),
|
|
staleTime: 30_000,
|
|
retry: false,
|
|
})),
|
|
});
|
|
|
|
const issueById = useMemo(() => {
|
|
const map = new Map<string, Issue>();
|
|
for (const query of issueQueries) {
|
|
const issue = query.data;
|
|
if (issue) map.set(issue.id, issue);
|
|
}
|
|
return map;
|
|
}, [issueQueries]);
|
|
|
|
const { transcriptByRun, hasOutputForRun } = useLiveRunTranscripts({
|
|
runs: visibleRuns,
|
|
companyId,
|
|
maxChunksPerRun: DASHBOARD_MAX_CHUNKS_PER_RUN,
|
|
logPollIntervalMs: DASHBOARD_LOG_POLL_INTERVAL_MS,
|
|
logReadLimitBytes: DASHBOARD_LOG_READ_LIMIT_BYTES,
|
|
enableRealtimeUpdates: false,
|
|
});
|
|
|
|
return (
|
|
<div>
|
|
<h3 className="mb-3 text-sm font-semibold uppercase tracking-wide text-muted-foreground">
|
|
{title}
|
|
</h3>
|
|
{runs.length === 0 ? (
|
|
<div className="rounded-xl border border-border p-4">
|
|
<p className="text-sm text-muted-foreground">{emptyMessage}</p>
|
|
</div>
|
|
) : (
|
|
<div className={cn("grid grid-cols-1 gap-2 sm:grid-cols-2 sm:gap-4 xl:grid-cols-4", gridClassName)}>
|
|
{visibleRuns.map((run) => (
|
|
<AgentRunCard
|
|
key={run.id}
|
|
companyId={companyId}
|
|
run={run}
|
|
issue={run.issueId ? issueById.get(run.issueId) : undefined}
|
|
transcript={transcriptByRun.get(run.id) ?? EMPTY_TRANSCRIPT}
|
|
hasOutput={hasOutputForRun(run.id)}
|
|
isActive={isRunActive(run)}
|
|
className={cardClassName}
|
|
/>
|
|
))}
|
|
</div>
|
|
)}
|
|
{showMoreLink && hiddenRunCount > 0 && (
|
|
<div className="mt-3 flex justify-end text-xs text-muted-foreground">
|
|
<Link to="/dashboard/live" className="hover:text-foreground hover:underline">
|
|
{hiddenRunCount} more active/recent run{hiddenRunCount === 1 ? "" : "s"}
|
|
</Link>
|
|
</div>
|
|
)}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
const AgentRunCard = memo(function AgentRunCard({
|
|
companyId,
|
|
run,
|
|
issue,
|
|
transcript,
|
|
hasOutput,
|
|
isActive,
|
|
className,
|
|
}: {
|
|
companyId: string;
|
|
run: LiveRunForIssue;
|
|
issue?: Issue;
|
|
transcript: TranscriptEntry[];
|
|
hasOutput: boolean;
|
|
isActive: boolean;
|
|
className?: string;
|
|
}) {
|
|
return (
|
|
<div className={cn(
|
|
"flex h-[320px] flex-col overflow-hidden rounded-xl border shadow-sm",
|
|
isActive
|
|
? "border-cyan-500/25 bg-cyan-500/[0.04] shadow-[0_16px_40px_rgba(6,182,212,0.08)]"
|
|
: "border-border bg-background/70",
|
|
className,
|
|
)}>
|
|
<div className="border-b border-border/60 px-3 py-3">
|
|
<div className="flex items-start justify-between gap-2">
|
|
<div className="min-w-0">
|
|
<div className="flex items-center gap-2">
|
|
{isActive ? (
|
|
<span className="relative flex h-2.5 w-2.5 shrink-0">
|
|
<span className="absolute inline-flex h-full w-full animate-ping rounded-full bg-cyan-400 opacity-70" />
|
|
<span className="relative inline-flex h-2.5 w-2.5 rounded-full bg-cyan-500" />
|
|
</span>
|
|
) : (
|
|
<span className="inline-flex h-2.5 w-2.5 rounded-full bg-muted-foreground/35" />
|
|
)}
|
|
<Identity name={run.agentName} size="sm" className="[&>span:last-child]:!text-[11px]" />
|
|
</div>
|
|
<div className="mt-2 flex items-center gap-2 text-[11px] text-muted-foreground">
|
|
<span>{isActive ? "Live now" : run.finishedAt ? `Finished ${relativeTime(run.finishedAt)}` : `Started ${relativeTime(run.createdAt)}`}</span>
|
|
</div>
|
|
</div>
|
|
|
|
<Link
|
|
to={`/agents/${run.agentId}/runs/${run.id}`}
|
|
className="inline-flex items-center gap-1 rounded-full border border-border/70 bg-background/70 px-2 py-1 text-[10px] text-muted-foreground transition-colors hover:text-foreground"
|
|
>
|
|
<ExternalLink className="h-2.5 w-2.5" />
|
|
</Link>
|
|
</div>
|
|
|
|
{run.issueId && (
|
|
<div className="mt-3 rounded-lg border border-border/60 bg-background/60 px-2.5 py-2 text-xs">
|
|
<Link
|
|
to={`/issues/${issue?.identifier ?? run.issueId}`}
|
|
className={cn(
|
|
"line-clamp-2 hover:underline",
|
|
isActive ? "text-cyan-700 dark:text-cyan-300" : "text-muted-foreground hover:text-foreground",
|
|
)}
|
|
title={issue?.title ? `${issue?.identifier ?? run.issueId.slice(0, 8)} - ${issue.title}` : issue?.identifier ?? run.issueId.slice(0, 8)}
|
|
>
|
|
{issue?.identifier ?? run.issueId.slice(0, 8)}
|
|
{issue?.title ? ` - ${issue.title}` : ""}
|
|
</Link>
|
|
{issue?.activeRecoveryAction ? (
|
|
<div className="mt-1.5">
|
|
<RunCardRecoveryChip action={issue.activeRecoveryAction} />
|
|
</div>
|
|
) : null}
|
|
</div>
|
|
)}
|
|
</div>
|
|
|
|
<div className="min-h-0 flex-1 overflow-y-auto p-3">
|
|
<RunChatSurface
|
|
run={run}
|
|
transcript={transcript}
|
|
hasOutput={hasOutput}
|
|
companyId={companyId}
|
|
/>
|
|
</div>
|
|
</div>
|
|
);
|
|
});
|