mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-15 18:30:39 +09:00
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies through company-scoped issues, comments, approvals, and execution workspaces. > - Operators need the Inbox to show not only active work, but also blocked work that may need human or agent attention. > - The existing inbox experience did not have a dedicated blocked-work surface, so blocked tasks were harder to triage and resume deliberately. > - Backend consumers also needed a compact attention signal that distinguishes actionable blockers from covered or waiting blocker states. > - This pull request adds a Blocked Inbox tab backed by issue blocker-attention metadata, shared validators, and UI helpers. > - The benefit is a clearer triage path for stalled or blocked Paperclip work without exposing external wait internals in the operator-facing UI. ## What Changed - Added shared issue blocker-attention types, validators, and exports for the API/UI contract. - Added backend blocker-attention computation and issue route support for blocked inbox data. - Added the Blocked Inbox tab, blocked reason chips, filtering/search UI, responsive layouts, and Storybook stories. - Updated inbox helpers and page behavior so toolbar controls only appear where they apply. - Added coverage for shared validators, server blocker-attention behavior, blocked inbox UI helpers/components, and the Inbox page. - Added a screenshot helper script for the blocked inbox Storybook stories. - Addressed Greptile feedback by making urgency sorting deterministic for null stop times, avoiding full blocked-inbox list enrichment for counts, and hardening the screenshot helper. ## Verification - Rebased the branch cleanly onto `public-gh/master`. - Confirmed the diff does not include `pnpm-lock.yaml`. - Confirmed the diff does not include database migration files. - Ran `pnpm exec vitest run packages/shared/src/validators/issue.test.ts server/src/__tests__/issue-blocker-attention.test.ts ui/src/components/BlockedInboxView.test.tsx ui/src/components/BlockedReasonChip.test.tsx ui/src/lib/blockedInbox.test.ts ui/src/lib/inbox.test.ts ui/src/pages/Inbox.test.tsx`. - Ran `pnpm --filter @paperclipai/shared typecheck && pnpm --filter @paperclipai/server typecheck && pnpm --filter @paperclipai/ui typecheck`. - Checked `ROADMAP.md`; this is scoped inbox/operator triage work and does not duplicate a listed roadmap feature. - Greptile Review is green on the latest head and all four Greptile review threads are resolved. - GitHub PR checks are green on the latest head: policy, security/snyk, e2e, verify, Canary Dry Run, Greptile Review, and serialized server suites 1/4 through 4/4. ## Risks - Medium review surface because this touches the shared issue contract, server issue services, and the Inbox UI together. - Blocker-attention classification may need product tuning after operators use it on real blocked queues. - UI screenshots were not attached in this PR-opening pass; the branch includes `scripts/screenshot-blocked-inbox.mjs` and Storybook stories for visual capture. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used OpenAI Codex, GPT-5-based coding agent with shell, git, GitHub CLI, GitHub connector, and Paperclip API tool use. Reasoning mode: medium. Context window: not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
275 lines
9.1 KiB
TypeScript
275 lines
9.1 KiB
TypeScript
import type {
|
|
Issue,
|
|
IssueBlockedInboxAttention,
|
|
IssueBlockedInboxReason,
|
|
IssueBlockedInboxSeverity,
|
|
} from "@paperclipai/shared";
|
|
|
|
export type BlockedReasonVariant =
|
|
| "needs_decision"
|
|
| "stalled"
|
|
| "needs_attention"
|
|
| "recovery_required"
|
|
| "external_wait"
|
|
| "owner_paused";
|
|
|
|
const VARIANT_BY_REASON: Record<IssueBlockedInboxReason, BlockedReasonVariant> = {
|
|
pending_board_decision: "needs_decision",
|
|
pending_user_decision: "needs_decision",
|
|
missing_successful_run_disposition: "needs_decision",
|
|
blocked_chain_stalled: "stalled",
|
|
blocked_by_unassigned_issue: "needs_attention",
|
|
blocked_by_assigned_backlog_issue: "needs_attention",
|
|
blocked_by_cancelled_issue: "needs_attention",
|
|
in_review_without_action_path: "needs_attention",
|
|
invalid_review_participant: "needs_attention",
|
|
open_recovery_issue: "recovery_required",
|
|
external_owner_action: "external_wait",
|
|
blocked_by_uninvokable_assignee: "owner_paused",
|
|
};
|
|
|
|
export const BLOCKED_REASON_VARIANT_ORDER: BlockedReasonVariant[] = [
|
|
"needs_decision",
|
|
"stalled",
|
|
"needs_attention",
|
|
"recovery_required",
|
|
"external_wait",
|
|
"owner_paused",
|
|
];
|
|
|
|
export const BLOCKED_VARIANT_LABELS: Record<BlockedReasonVariant, string> = {
|
|
needs_decision: "Needs decision",
|
|
stalled: "Blocked chain stalled",
|
|
needs_attention: "Needs attention",
|
|
recovery_required: "Recovery required",
|
|
external_wait: "External wait",
|
|
owner_paused: "Owner paused",
|
|
};
|
|
|
|
const REASON_LABELS: Record<IssueBlockedInboxReason, string> = {
|
|
pending_board_decision: "Pending board decision",
|
|
pending_user_decision: "Pending user decision",
|
|
missing_successful_run_disposition: "Pick disposition",
|
|
blocked_chain_stalled: "Blocked chain stalled",
|
|
blocked_by_unassigned_issue: "Unassigned blocker",
|
|
blocked_by_assigned_backlog_issue: "Parked blocker",
|
|
blocked_by_cancelled_issue: "Cancelled blocker",
|
|
in_review_without_action_path: "Review without action path",
|
|
invalid_review_participant: "Invalid review participant",
|
|
open_recovery_issue: "Recovery in progress",
|
|
external_owner_action: "External owner action",
|
|
blocked_by_uninvokable_assignee: "Owner paused",
|
|
};
|
|
|
|
const SEVERITY_RANK: Record<IssueBlockedInboxSeverity, number> = {
|
|
critical: 0,
|
|
high: 1,
|
|
medium: 2,
|
|
low: 3,
|
|
};
|
|
|
|
export type BlockedInboxBadgeTone = "muted" | "amber" | "red";
|
|
|
|
export function blockedReasonVariant(reason: IssueBlockedInboxReason): BlockedReasonVariant {
|
|
return VARIANT_BY_REASON[reason] ?? "needs_attention";
|
|
}
|
|
|
|
export function blockedReasonLabel(reason: IssueBlockedInboxReason): string {
|
|
return REASON_LABELS[reason] ?? "Stopped";
|
|
}
|
|
|
|
export function blockedVariantLabel(variant: BlockedReasonVariant): string {
|
|
return BLOCKED_VARIANT_LABELS[variant];
|
|
}
|
|
|
|
export function blockedSeverityRank(severity: IssueBlockedInboxSeverity): number {
|
|
return SEVERITY_RANK[severity] ?? 9;
|
|
}
|
|
|
|
export function compareBlockedAttention(
|
|
a: IssueBlockedInboxAttention,
|
|
b: IssueBlockedInboxAttention,
|
|
): number {
|
|
const sevDiff = blockedSeverityRank(a.severity) - blockedSeverityRank(b.severity);
|
|
if (sevDiff !== 0) return sevDiff;
|
|
const aSince = a.stoppedSinceAt ? new Date(a.stoppedSinceAt).getTime() : Number.POSITIVE_INFINITY;
|
|
const bSince = b.stoppedSinceAt ? new Date(b.stoppedSinceAt).getTime() : Number.POSITIVE_INFINITY;
|
|
const sinceDiff = aSince - bSince;
|
|
return Number.isFinite(sinceDiff) ? sinceDiff : 0;
|
|
}
|
|
|
|
export interface BlockedInboxIssueRow {
|
|
issue: Issue;
|
|
attention: IssueBlockedInboxAttention;
|
|
variant: BlockedReasonVariant;
|
|
reasonLabel: string;
|
|
stoppedAtMs: number | null;
|
|
}
|
|
|
|
export type BlockedInboxGroupBy = "blocker_type" | "none";
|
|
export type BlockedInboxSort = "urgency" | "most_recent" | "longest_stopped";
|
|
|
|
export const BLOCKED_GROUP_OPTIONS: readonly [BlockedInboxGroupBy, string][] = [
|
|
["blocker_type", "Blocker type"],
|
|
["none", "None"],
|
|
];
|
|
|
|
export const BLOCKED_SORT_OPTIONS: readonly [BlockedInboxSort, string][] = [
|
|
["urgency", "Most urgent"],
|
|
["most_recent", "Most recent"],
|
|
["longest_stopped", "Longest stopped"],
|
|
];
|
|
|
|
export interface BlockedInboxGroup {
|
|
variant: BlockedReasonVariant;
|
|
label: string;
|
|
rows: BlockedInboxIssueRow[];
|
|
}
|
|
|
|
export function buildBlockedInboxRows(issues: readonly Issue[]): BlockedInboxIssueRow[] {
|
|
const rows: BlockedInboxIssueRow[] = [];
|
|
for (const issue of issues) {
|
|
const attention = issue.blockedInboxAttention;
|
|
if (!attention) continue;
|
|
rows.push({
|
|
issue,
|
|
attention,
|
|
variant: blockedReasonVariant(attention.reason),
|
|
reasonLabel: blockedReasonLabel(attention.reason),
|
|
stoppedAtMs: attention.stoppedSinceAt ? new Date(attention.stoppedSinceAt).getTime() : null,
|
|
});
|
|
}
|
|
return rows;
|
|
}
|
|
|
|
function issueTimestampMs(value: Date | string | null | undefined): number | null {
|
|
if (!value) return null;
|
|
const timestamp = new Date(value).getTime();
|
|
return Number.isFinite(timestamp) ? timestamp : null;
|
|
}
|
|
|
|
function blockedRowRecencyMs(row: BlockedInboxIssueRow): number {
|
|
return row.stoppedAtMs ?? issueTimestampMs(row.issue.updatedAt) ?? 0;
|
|
}
|
|
|
|
function compareBlockedRowsByTitle(a: BlockedInboxIssueRow, b: BlockedInboxIssueRow): number {
|
|
const byTitle = a.issue.title.localeCompare(b.issue.title);
|
|
if (byTitle !== 0) return byTitle;
|
|
return a.issue.id.localeCompare(b.issue.id);
|
|
}
|
|
|
|
export function compareBlockedRows(
|
|
a: BlockedInboxIssueRow,
|
|
b: BlockedInboxIssueRow,
|
|
sort: BlockedInboxSort = "urgency",
|
|
): number {
|
|
if (sort === "most_recent") {
|
|
const recencyDiff = blockedRowRecencyMs(b) - blockedRowRecencyMs(a);
|
|
if (recencyDiff !== 0) return recencyDiff;
|
|
const attentionDiff = compareBlockedAttention(a.attention, b.attention);
|
|
if (attentionDiff !== 0) return attentionDiff;
|
|
return compareBlockedRowsByTitle(a, b);
|
|
}
|
|
|
|
if (sort === "longest_stopped") {
|
|
const aStopped = a.stoppedAtMs ?? Number.POSITIVE_INFINITY;
|
|
const bStopped = b.stoppedAtMs ?? Number.POSITIVE_INFINITY;
|
|
const stoppedDiff = aStopped - bStopped;
|
|
if (stoppedDiff !== 0) return stoppedDiff;
|
|
const severityDiff = blockedSeverityRank(a.attention.severity) - blockedSeverityRank(b.attention.severity);
|
|
if (severityDiff !== 0) return severityDiff;
|
|
return compareBlockedRowsByTitle(a, b);
|
|
}
|
|
|
|
const attentionDiff = compareBlockedAttention(a.attention, b.attention);
|
|
if (attentionDiff !== 0) return attentionDiff;
|
|
const recencyDiff = blockedRowRecencyMs(b) - blockedRowRecencyMs(a);
|
|
if (recencyDiff !== 0) return recencyDiff;
|
|
return compareBlockedRowsByTitle(a, b);
|
|
}
|
|
|
|
export function sortBlockedInboxRows(
|
|
rows: readonly BlockedInboxIssueRow[],
|
|
sort: BlockedInboxSort = "urgency",
|
|
): BlockedInboxIssueRow[] {
|
|
return [...rows].sort((a, b) => compareBlockedRows(a, b, sort));
|
|
}
|
|
|
|
export function groupBlockedInboxRows(
|
|
rows: readonly BlockedInboxIssueRow[],
|
|
sort: BlockedInboxSort = "urgency",
|
|
): BlockedInboxGroup[] {
|
|
const buckets = new Map<BlockedReasonVariant, BlockedInboxIssueRow[]>();
|
|
for (const row of rows) {
|
|
const list = buckets.get(row.variant) ?? [];
|
|
list.push(row);
|
|
buckets.set(row.variant, list);
|
|
}
|
|
const groups: BlockedInboxGroup[] = [];
|
|
for (const variant of BLOCKED_REASON_VARIANT_ORDER) {
|
|
const list = buckets.get(variant);
|
|
if (!list || list.length === 0) continue;
|
|
const sorted = sortBlockedInboxRows(list, sort);
|
|
groups.push({ variant, label: BLOCKED_VARIANT_LABELS[variant], rows: sorted });
|
|
}
|
|
return groups;
|
|
}
|
|
|
|
export function blockedRowMatchesSearch(row: BlockedInboxIssueRow, query: string): boolean {
|
|
const q = query.trim().toLowerCase();
|
|
if (!q) return true;
|
|
const haystack = [
|
|
row.issue.title,
|
|
row.issue.identifier ?? "",
|
|
row.attention.owner.label ?? "",
|
|
row.attention.action.label,
|
|
row.attention.action.detail ?? "",
|
|
row.reasonLabel,
|
|
row.attention.leafIssue?.identifier ?? "",
|
|
row.attention.leafIssue?.title ?? "",
|
|
row.attention.recoveryIssue?.identifier ?? "",
|
|
row.attention.recoveryIssue?.title ?? "",
|
|
]
|
|
.join(" ")
|
|
.toLowerCase();
|
|
return haystack.includes(q);
|
|
}
|
|
|
|
export function blockedBadgeTone(rows: readonly BlockedInboxIssueRow[]): BlockedInboxBadgeTone {
|
|
if (rows.length === 0) return "muted";
|
|
let highest: IssueBlockedInboxSeverity = "low";
|
|
for (const row of rows) {
|
|
if (blockedSeverityRank(row.attention.severity) < blockedSeverityRank(highest)) {
|
|
highest = row.attention.severity;
|
|
}
|
|
}
|
|
if (highest === "critical") return "red";
|
|
if (highest === "high") return "amber";
|
|
return "muted";
|
|
}
|
|
|
|
export function formatStoppedAge(stoppedSinceAt: string | null, now: number = Date.now()): string {
|
|
if (!stoppedSinceAt) return "stopped";
|
|
const then = new Date(stoppedSinceAt).getTime();
|
|
if (!Number.isFinite(then)) return "stopped";
|
|
const seconds = Math.max(0, Math.round((now - then) / 1000));
|
|
if (seconds < 60) return "stopped just now";
|
|
if (seconds < 3600) {
|
|
const m = Math.floor(seconds / 60);
|
|
return `stopped ${m}m`;
|
|
}
|
|
if (seconds < 86_400) {
|
|
const h = Math.floor(seconds / 3600);
|
|
return `stopped ${h}h`;
|
|
}
|
|
if (seconds < 86_400 * 7) {
|
|
const d = Math.floor(seconds / 86_400);
|
|
return `stopped ${d}d`;
|
|
}
|
|
if (seconds < 86_400 * 30) {
|
|
const w = Math.floor(seconds / (86_400 * 7));
|
|
return `stopped ${w}w`;
|
|
}
|
|
const mo = Math.floor(seconds / (86_400 * 30));
|
|
return `stopped ${mo}mo`;
|
|
}
|