mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-14 18:10:39 +09:00
38c185fb8b
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies by keeping task ownership, approvals, and operator control inside one control plane. > - Agent permissions and plugin-hosted company settings sit on the boundary between autonomy and governance. > - V1 needs scoped task assignment rules, plugin extension points, and clearer company access surfaces without weakening company boundaries. > - The branch builds the core authorization service, plugin SDK/host APIs, and UI simplifications needed to support those controls. > - Paperclip EE plugin surfaces were intentionally moved out of this core PR per review direction, so this PR now carries only the public core/plugin infrastructure work. > - The latest updates preserve the PAP-9937 branch changes that belong in this PR, remove the `design/` artifacts, and exclude the experimental `plugin-briefs` package. > - Greptile feedback was applied through the authorization/audit paths and the final cleanup commit was re-reviewed at 5/5 with no unresolved Greptile threads. > - The benefit is safer assignment control with extension hooks for richer permission products while preserving simple defaults for normal operators. ## What Changed - Added scoped task-assignment authorization decisions and routed issue/agent assignment mutations through the authorization service. - Added plugin SDK and host APIs for company settings slots, authorization policy/grant management, assignment previews, and bridge invocation scope propagation. - Simplified core company access UI and moved advanced controls behind plugin-provided settings surfaces. - Added retry-now affordances for blocked issue next-step notices. - Added protected-assignment enforcement for persisted agent/project/issue policies, including explicit-grant fallback behavior. - Added incremental principal-access compatibility backfill for active agent memberships and role-default human permission grants. - Added the Markdown code block wrap action fix from the latest branch changes. - Removed `design/` artifacts from the PR and removed `packages/plugins/plugin-briefs` from the final diff. - Addressed Greptile feedback for plugin actor sanitization, legacy membership handling, audit pagination, unknown grant-scope metadata, and startup test mocks. ## Verification - `pnpm exec vitest run server/src/__tests__/access-service.test.ts server/src/__tests__/company-portability.test.ts` -> 2 files passed, 54 tests passed. - `pnpm exec vitest run server/src/__tests__/server-startup-feedback-export.test.ts server/src/__tests__/access-service.test.ts server/src/__tests__/company-portability.test.ts` -> 3 files passed, 62 tests passed. - `pnpm exec vitest run server/src/__tests__/authorization-service.test.ts server/src/__tests__/plugin-access-authorization-host-services.test.ts server/src/__tests__/server-startup-feedback-export.test.ts` -> 3 files passed, 28 tests passed. - `pnpm --filter @paperclipai/server typecheck` -> passed. - `git diff --check` -> passed. - `node ./scripts/check-docker-deps-stage.mjs` -> passed. - `CI=true pnpm install --frozen-lockfile --ignore-scripts` -> passed with no lockfile update. - `pnpm exec vitest run ui/src/components/MarkdownBody.interaction.test.tsx` -> 1 test passed. - `git ls-files design packages/plugins/plugin-briefs | wc -l` -> 0. - GitHub CI on `40cd83b53` -> all checks passed, merge state `CLEAN`. - Greptile on `40cd83b53` -> 5/5, 102 files reviewed, 0 comments/annotations added, 0 unresolved review threads. - Confirmed the PR diff contains no `design/`, `packages/plugins/plugin-briefs`, `pnpm-lock.yaml`, or `.github/workflows` changes. ## Risks - Medium: task assignment authorization paths are behaviorally stricter for protected/private policy data, so existing plugin-authored policies may block assignment until explicit grants or approval flows are configured. - Medium: plugin-host authorization APIs expand the surface area available to trusted plugins and need careful review for company scoping. - Low: startup now performs a principal-access compatibility backfill, but the migration and runtime backfill use conflict-tolerant inserts. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent, tool-enabled workflow with shell, git, and GitHub CLI access. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> |
||
|---|---|---|
| .. | ||
| acpx-model-filter.test.ts | ||
| acpx-model-filter.ts | ||
| activity-format.test.ts | ||
| activity-format.ts | ||
| agent-config-patch.test.ts | ||
| agent-config-patch.ts | ||
| agent-icons.ts | ||
| agent-order.ts | ||
| agent-skills-state.test.ts | ||
| agent-skills-state.ts | ||
| assignees.test.ts | ||
| assignees.ts | ||
| blockedInbox.test.ts | ||
| blockedInbox.ts | ||
| color-contrast.ts | ||
| comment-submit-draft.test.ts | ||
| comment-submit-draft.ts | ||
| company-export-selection.test.ts | ||
| company-export-selection.ts | ||
| company-members.test.ts | ||
| company-members.ts | ||
| company-page-memory.ts | ||
| company-portability-sidebar.test.ts | ||
| company-portability-sidebar.ts | ||
| company-routes.test.ts | ||
| company-routes.ts | ||
| company-selection.test.ts | ||
| company-selection.ts | ||
| document-revisions.test.ts | ||
| document-revisions.ts | ||
| duplicate-agent-payload.test.ts | ||
| duplicate-agent-payload.ts | ||
| groupBy.ts | ||
| inbox.test.ts | ||
| inbox.ts | ||
| instance-settings.test.ts | ||
| instance-settings.ts | ||
| invite-memory.ts | ||
| issue-assignee-overrides.test.ts | ||
| issue-assignee-overrides.ts | ||
| issue-blockers.ts | ||
| issue-chat-messages.test.ts | ||
| issue-chat-messages.ts | ||
| issue-chat-scroll.test.ts | ||
| issue-chat-scroll.ts | ||
| issue-detail-subissues.test.ts | ||
| issue-detail-subissues.ts | ||
| issue-execution-policy.ts | ||
| issue-filters.test.ts | ||
| issue-filters.ts | ||
| issue-monitor.ts | ||
| issue-properties-panel-key.test.ts | ||
| issue-properties-panel-key.ts | ||
| issue-reference.test.ts | ||
| issue-reference.ts | ||
| issue-thread-interactions.test.ts | ||
| issue-thread-interactions.ts | ||
| issue-timeline-events.test.ts | ||
| issue-timeline-events.ts | ||
| issue-tree.test.ts | ||
| issue-tree.ts | ||
| issueActiveRun.test.ts | ||
| issueActiveRun.ts | ||
| issueChatTranscriptRuns.test.ts | ||
| issueChatTranscriptRuns.ts | ||
| issueDetailBreadcrumb.test.ts | ||
| issueDetailBreadcrumb.ts | ||
| issueDetailCache.test.ts | ||
| issueDetailCache.ts | ||
| issueDetailQuery.test.tsx | ||
| keyboardShortcuts.test.ts | ||
| keyboardShortcuts.ts | ||
| legacy-agent-config.test.ts | ||
| legacy-agent-config.ts | ||
| line-diff.test.ts | ||
| line-diff.ts | ||
| liveIssueIds.test.ts | ||
| liveIssueIds.ts | ||
| main-content-focus.test.ts | ||
| main-content-focus.ts | ||
| markdownPaste.test.ts | ||
| markdownPaste.ts | ||
| mention-aware-link-node.test.ts | ||
| mention-aware-link-node.ts | ||
| mention-chips.ts | ||
| mention-deletion.test.ts | ||
| mention-deletion.ts | ||
| model-utils.ts | ||
| navigation-scroll.test.ts | ||
| navigation-scroll.ts | ||
| new-agent-hire-payload.test.ts | ||
| new-agent-hire-payload.ts | ||
| new-agent-runtime-config.test.ts | ||
| new-agent-runtime-config.ts | ||
| normalize-markdown.test.ts | ||
| normalize-markdown.ts | ||
| onboarding-goal.test.ts | ||
| onboarding-goal.ts | ||
| onboarding-launch.test.ts | ||
| onboarding-launch.ts | ||
| onboarding-route.test.ts | ||
| onboarding-route.ts | ||
| optimistic-issue-comments.test.ts | ||
| optimistic-issue-comments.ts | ||
| optimistic-issue-runs.test.ts | ||
| optimistic-issue-runs.ts | ||
| paste-normalization.ts | ||
| portable-files.ts | ||
| project-order.ts | ||
| project-workspaces-tab.test.ts | ||
| project-workspaces-tab.ts | ||
| query-placeholder-data.test.tsx | ||
| query-placeholder-data.ts | ||
| queryKeys.ts | ||
| recent-assignees.ts | ||
| recent-projects.ts | ||
| recent-searches.ts | ||
| recent-selections.test.ts | ||
| recent-selections.ts | ||
| recovery-display.ts | ||
| remark-soft-breaks.ts | ||
| reusable-execution-workspaces.test.ts | ||
| reusable-execution-workspaces.ts | ||
| router.tsx | ||
| routine-trigger-patch.test.ts | ||
| routine-trigger-patch.ts | ||
| runRetryState.test.ts | ||
| runRetryState.ts | ||
| source-resolved-watchdog-fold.ts | ||
| status-colors.ts | ||
| subIssueDefaults.test.ts | ||
| subIssueDefaults.ts | ||
| successful-run-handoff.test.ts | ||
| successful-run-handoff.ts | ||
| system-notice-comment.test.ts | ||
| system-notice-comment.ts | ||
| timeAgo.ts | ||
| transcriptPresentation.test.ts | ||
| transcriptPresentation.ts | ||
| utils.ts | ||
| vite-watch.test.ts | ||
| vite-watch.ts | ||
| websocket-url.test.ts | ||
| websocket-url.ts | ||
| workflow-sort.test.ts | ||
| workflow-sort.ts | ||
| workspace-routines.test.ts | ||
| workspace-routines.ts | ||
| worktree-branding.ts | ||
| zip.test.ts | ||
| zip.ts | ||