mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-15 02:20:38 +09:00
68f69975a4
## Thinking Path > - Paperclip relies on issue identifiers, execution policies, and agent heartbeat rules to keep autonomous work auditable. > - Safety checks need to reject ambiguous agent handoffs, and identifier parsing needs to support Cloud tenant prefixes. > - Agent instructions also need to make final-disposition rules explicit so work does not stall in vague states. > - This pull request isolates backend correctness and governance hardening from the UI and recovery-system-notice branches. > - The benefit is safer in-review transitions, better identifier compatibility, and clearer agent operating contracts. ## What Changed - Fixed run-aware confirmation ordering and interrupted-run state cleanup. - Added Cloud tenant identity bootstrap and alphanumeric issue identifier support across shared parsing and server routes. - Guarded agent-authored `in_review` updates unless a real review path exists. - Tightened heartbeat disposition instructions in adapter utilities/default AGENTS/Paperclip skill. ## Verification - `pnpm install --frozen-lockfile` - `pnpm exec vitest run packages/shared/src/issue-references.test.ts server/src/__tests__/issue-identifier-routes.test.ts server/src/__tests__/issue-execution-policy-routes.test.ts packages/adapter-utils/src/server-utils.test.ts` initially had the first execution-policy test hit Vitest's 5s timeout under the parallel bundle while the rest passed. - `pnpm exec vitest run server/src/__tests__/issue-execution-policy-routes.test.ts --testTimeout=20000` passed with 10/10 tests. - Follow-up: `pnpm run typecheck:build-gaps` passed. - Follow-up: `pnpm --filter @paperclipai/ui typecheck` passed. - Follow-up: `pnpm vitest run server/src/__tests__/issue-comment-reopen-routes.test.ts server/src/__tests__/company-portability.test.ts server/src/__tests__/costs-service.test.ts` passed. - Follow-up: `pnpm vitest run ui/src/context/LiveUpdatesProvider.test.ts ui/src/lib/issue-chat-messages.test.ts ui/src/lib/issue-reference.test.ts ui/src/lib/issue-timeline-events.test.ts` passed. ## Risks - Medium control-plane risk: in-review update validation changes agent behavior. The error message is explicit and tests cover allowed review paths. ## Model Used - OpenAI GPT-5 Codex via Paperclip `codex_local` adapter, with shell/git/GitHub CLI tool use. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
69 lines
3.1 KiB
TypeScript
69 lines
3.1 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { parseIssuePathIdFromPath, parseIssueReferenceFromHref } from "./issue-reference";
|
|
|
|
describe("issue-reference", () => {
|
|
it("extracts issue ids from company-scoped issue paths", () => {
|
|
expect(parseIssuePathIdFromPath("/PAP/issues/PAP-1271")).toBe("PAP-1271");
|
|
expect(parseIssuePathIdFromPath("/PAP/issues/pap-1272")).toBe("PAP-1272");
|
|
expect(parseIssuePathIdFromPath("/issues/pc1a2-7")).toBe("PC1A2-7");
|
|
expect(parseIssuePathIdFromPath("/PC1A2/issues/pc1a2-7")).toBe("PC1A2-7");
|
|
expect(parseIssuePathIdFromPath("/issues/PAP-1179")).toBe("PAP-1179");
|
|
expect(parseIssuePathIdFromPath("/issues/:id")).toBeNull();
|
|
});
|
|
|
|
it("does not treat full issue URLs as internal issue paths", () => {
|
|
expect(parseIssuePathIdFromPath("http://localhost:3100/PAP/issues/PAP-1179")).toBeNull();
|
|
expect(parseIssuePathIdFromPath("http://remote.example.test:3103/PAPA/issues/PAPA-115#comment-850083f3-24de-43e7-a8cd-bc01f7cc9f0d")).toBeNull();
|
|
});
|
|
|
|
it("does not treat GitHub issue URLs as internal Paperclip issue links", () => {
|
|
expect(parseIssuePathIdFromPath("https://github.com/paperclipai/paperclip/issues/1778")).toBeNull();
|
|
expect(parseIssueReferenceFromHref("https://github.com/paperclipai/paperclip/issues/1778")).toBeNull();
|
|
});
|
|
|
|
it("ignores placeholder issue paths", () => {
|
|
expect(parseIssuePathIdFromPath("/issues/:id")).toBeNull();
|
|
expect(parseIssuePathIdFromPath("http://localhost:3100/issues/:id")).toBeNull();
|
|
expect(parseIssueReferenceFromHref("/issues/:id")).toBeNull();
|
|
});
|
|
|
|
it("normalizes bare identifiers, relative issue paths, and issue scheme links into internal links", () => {
|
|
expect(parseIssueReferenceFromHref("pap-1271")).toEqual({
|
|
issuePathId: "PAP-1271",
|
|
href: "/issues/PAP-1271",
|
|
});
|
|
expect(parseIssueReferenceFromHref("pc1a2-7")).toEqual({
|
|
issuePathId: "PC1A2-7",
|
|
href: "/issues/PC1A2-7",
|
|
});
|
|
expect(parseIssueReferenceFromHref("/PAP/issues/pap-1180")).toEqual({
|
|
issuePathId: "PAP-1180",
|
|
href: "/issues/PAP-1180",
|
|
});
|
|
expect(parseIssueReferenceFromHref("issue://PAP-1310")).toEqual({
|
|
issuePathId: "PAP-1310",
|
|
href: "/issues/PAP-1310",
|
|
});
|
|
expect(parseIssueReferenceFromHref("issue://:PAP-1311")).toEqual({
|
|
issuePathId: "PAP-1311",
|
|
href: "/issues/PAP-1311",
|
|
});
|
|
});
|
|
|
|
it("normalizes exact inline-code-like issue identifiers", () => {
|
|
expect(parseIssueReferenceFromHref("PAP-1271")).toEqual({
|
|
issuePathId: "PAP-1271",
|
|
href: "/issues/PAP-1271",
|
|
});
|
|
});
|
|
|
|
it("preserves absolute Paperclip issue URLs so origin, port, and hash are not lost", () => {
|
|
expect(parseIssueReferenceFromHref("http://localhost:3100/PAP/issues/PAP-1179")).toBeNull();
|
|
expect(parseIssueReferenceFromHref("http://remote.example.test:3103/PAPA/issues/PAPA-115#comment-850083f3-24de-43e7-a8cd-bc01f7cc9f0d")).toBeNull();
|
|
});
|
|
|
|
it("ignores literal route placeholder paths", () => {
|
|
expect(parseIssueReferenceFromHref("/issues/:id")).toBeNull();
|
|
expect(parseIssueReferenceFromHref("http://localhost:3100/api/issues/:id")).toBeNull();
|
|
});
|
|
});
|