mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-16 10:50:38 +09:00
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies. > - Agent runs can end productively while the source issue still lacks a durable final disposition. > - That leaves the control plane unsure whether to resume, escalate, or close the work. > - Issue comments also need a presentation contract so system-authored recovery notices can render as first-class thread messages without overloading normal comments. > - This pull request adds successful-run handoff recovery, comment presentation metadata, and system notice rendering. > - The benefit is stricter task liveness with clearer operator-facing recovery state. ## What Changed - Added successful-run handoff decisions, wake payloads, escalation behavior, and recovery tests. - Added issue comment presentation metadata with migration `0078_white_darwin.sql` and shared/server/company portability support. - Rendered recovery/system notices in issue chat with dedicated UI components, fixtures, tests, and storybook/lab coverage. - Included the current recovery model-profile hint patch so automatic recovery follow-ups use the cheap profile. ## Verification - `pnpm install --frozen-lockfile` - `pnpm exec vitest run server/src/services/recovery/successful-run-handoff.test.ts ui/src/components/SystemNotice.test.tsx ui/src/lib/system-notice-comment.test.ts ui/src/components/IssueChatThreadSystemNotice.test.tsx` ## Risks - Migration-bearing PR: merge this before any other branch that might later add a migration. - The branch touches both recovery services and issue-thread rendering, so review should pay attention to recovery wake idempotency and comment metadata compatibility. ## Model Used - OpenAI GPT-5 Codex via Paperclip `codex_local` adapter, with shell/git/GitHub CLI tool use. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
125 lines
3.8 KiB
TypeScript
125 lines
3.8 KiB
TypeScript
import type {
|
|
IssueCommentMetadata,
|
|
IssueCommentMetadataRow,
|
|
IssueCommentPresentation,
|
|
} from "@paperclipai/shared";
|
|
import type {
|
|
SystemNoticeMetadataRow,
|
|
SystemNoticeMetadataSection,
|
|
SystemNoticeProps,
|
|
SystemNoticeTone,
|
|
} from "../components/SystemNotice";
|
|
|
|
const TONE_LABEL: Record<SystemNoticeTone, string> = {
|
|
neutral: "System notice",
|
|
info: "System notice",
|
|
success: "System notice",
|
|
warning: "System warning",
|
|
danger: "System alert",
|
|
};
|
|
|
|
function metadataRowText(row: { label?: string | null }, fallback: string) {
|
|
const label = row.label?.trim();
|
|
return label && label.length > 0 ? label : fallback;
|
|
}
|
|
|
|
function mapMetadataRow(
|
|
row: IssueCommentMetadataRow,
|
|
ctx: { runAgentId?: string | null },
|
|
): SystemNoticeMetadataRow | null {
|
|
switch (row.type) {
|
|
case "text":
|
|
return { kind: "text", label: metadataRowText(row, "Detail"), value: row.text };
|
|
case "code":
|
|
return { kind: "code", label: metadataRowText(row, "Code"), value: row.code };
|
|
case "key_value":
|
|
return { kind: "text", label: row.label, value: row.value };
|
|
case "issue_link": {
|
|
const identifier = row.identifier ?? null;
|
|
if (!identifier) {
|
|
return { kind: "text", label: metadataRowText(row, "Issue"), value: row.title ?? "unknown" };
|
|
}
|
|
return {
|
|
kind: "issue",
|
|
label: metadataRowText(row, "Issue"),
|
|
identifier,
|
|
href: `/issues/${identifier}`,
|
|
title: row.title ?? undefined,
|
|
};
|
|
}
|
|
case "agent_link": {
|
|
const name = row.name?.trim() || row.agentId.slice(0, 8);
|
|
return {
|
|
kind: "agent",
|
|
label: metadataRowText(row, "Agent"),
|
|
name,
|
|
href: `/agents/${row.agentId}`,
|
|
};
|
|
}
|
|
case "run_link": {
|
|
const runAgentId = ctx.runAgentId ?? null;
|
|
const href = runAgentId ? `/agents/${runAgentId}/runs/${row.runId}` : undefined;
|
|
return {
|
|
kind: "run",
|
|
label: metadataRowText(row, "Run"),
|
|
runId: row.runId,
|
|
href,
|
|
status: row.title ?? undefined,
|
|
};
|
|
}
|
|
default:
|
|
return null;
|
|
}
|
|
}
|
|
|
|
export function mapCommentMetadataToSystemNoticeSections(
|
|
metadata: IssueCommentMetadata | null | undefined,
|
|
ctx: { runAgentId?: string | null } = {},
|
|
): SystemNoticeMetadataSection[] {
|
|
if (!metadata || !Array.isArray(metadata.sections)) return [];
|
|
return metadata.sections
|
|
.map((section) => {
|
|
const rows = section.rows
|
|
.map((row) => mapMetadataRow(row, ctx))
|
|
.filter((r): r is SystemNoticeMetadataRow => r !== null);
|
|
if (rows.length === 0) return null;
|
|
const out: SystemNoticeMetadataSection = { rows };
|
|
if (section.title) out.title = section.title;
|
|
return out;
|
|
})
|
|
.filter((s): s is SystemNoticeMetadataSection => s !== null);
|
|
}
|
|
|
|
export function systemNoticeLabelForTone(
|
|
tone: SystemNoticeTone,
|
|
presentationTitle?: string | null,
|
|
): string {
|
|
const trimmed = presentationTitle?.trim();
|
|
if (trimmed && trimmed.length > 0) return trimmed;
|
|
return TONE_LABEL[tone];
|
|
}
|
|
|
|
export function buildSystemNoticeProps(input: {
|
|
presentation: IssueCommentPresentation | null;
|
|
metadata: IssueCommentMetadata | null;
|
|
body: import("react").ReactNode;
|
|
timestamp?: string;
|
|
source?: SystemNoticeProps["source"];
|
|
runAgentId?: string | null;
|
|
}): SystemNoticeProps {
|
|
const tone: SystemNoticeTone = input.presentation?.tone ?? "neutral";
|
|
const label = systemNoticeLabelForTone(tone, input.presentation?.title);
|
|
const detailsDefaultOpen = Boolean(input.presentation?.detailsDefaultOpen);
|
|
const sections = mapCommentMetadataToSystemNoticeSections(input.metadata, {
|
|
runAgentId: input.runAgentId ?? null,
|
|
});
|
|
return {
|
|
tone,
|
|
label,
|
|
body: input.body,
|
|
metadata: sections.length > 0 ? sections : undefined,
|
|
detailsDefaultOpen,
|
|
timestamp: input.timestamp,
|
|
source: input.source,
|
|
};
|
|
}
|