mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-16 19:00:38 +09:00
## Thinking Path > - Paperclip orchestrates AI-agent companies through company-scoped issues, comments, and execution context. > - The issue detail page is the board surface where operators and agents inspect a task in its parent/child workflow. > - Ordered sub-issues need a low-friction way to move through work without returning to the parent list after every issue. > - Existing issue detail navigation only covered sibling transitions and did not continue into a parent issue's first ordered child. > - This pull request adds ordered previous/next navigation for issue detail views and extends it to continue from a parent or last sibling into the first direct child. > - The benefit is a smoother review/execution path through hierarchical work while preserving hidden issue filtering and dependency-aware ordering. ## What Changed - Added `IssueSiblingNavigation` and route-state handling so issue detail footers can link to previous/next ordered issues. - Extended sub-issue ordering helpers to build navigation from siblings plus direct children, including root-parent and last-sibling-to-first-child cases. - Added page, component, and library tests for ordered sibling navigation, child fallback navigation, hidden issues, and link rendering. - Fixed the quicklook blur/click race Greptile found by deferring close until after portaled link clicks can complete, with a regression test. - Polished the navigation landmark label so it remains accurate when the next target is a direct child rather than a sibling. ## Verification - `pnpm exec vitest run src/components/IssueLinkQuicklook.test.tsx src/lib/issue-detail-subissues.test.ts src/components/IssueSiblingNavigation.test.tsx src/pages/IssueDetail.test.tsx --config vitest.config.ts` from `ui/` - 31 tests passed. - `pnpm --filter @paperclipai/ui typecheck` - passed. - `git diff --check` - passed. - GitHub PR checks on latest head `34046be2` - passed: Greptile Review, verify, e2e, Canary Dry Run, policy, Snyk, and serialized server shards. - Screenshots: not captured in this heartbeat; this PR is a draft and the changed states are covered by focused component/page tests. ## Risks - Low risk; this is a UI navigation addition with no database or API contract changes. - The main behavioral risk is navigation ordering drift if `workflowSort` expectations change later. - The IssueDetail navigation now waits for child issue loading, which avoids stale child fallback links but can delay footer navigation briefly while data loads. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected - check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent with repository tool use and shell execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
111 lines
3.6 KiB
TypeScript
111 lines
3.6 KiB
TypeScript
import * as React from "react";
|
|
import * as RouterDom from "react-router-dom";
|
|
import type { NavigateOptions, To } from "react-router-dom";
|
|
import type { Issue } from "@paperclipai/shared";
|
|
import { useCompany } from "@/context/CompanyContext";
|
|
import { IssueLinkQuicklook } from "@/components/IssueLinkQuicklook";
|
|
import {
|
|
applyCompanyPrefix,
|
|
extractCompanyPrefixFromPath,
|
|
normalizeCompanyPrefix,
|
|
} from "@/lib/company-routes";
|
|
import { parseIssuePathIdFromPath } from "@/lib/issue-reference";
|
|
|
|
function resolveTo(to: To, companyPrefix: string | null): To {
|
|
if (typeof to === "string") {
|
|
return applyCompanyPrefix(to, companyPrefix);
|
|
}
|
|
|
|
if (to.pathname && to.pathname.startsWith("/")) {
|
|
const pathname = applyCompanyPrefix(to.pathname, companyPrefix);
|
|
if (pathname !== to.pathname) {
|
|
return { ...to, pathname };
|
|
}
|
|
}
|
|
|
|
return to;
|
|
}
|
|
|
|
function useActiveCompanyPrefix(): string | null {
|
|
const { selectedCompany } = useCompany();
|
|
const params = RouterDom.useParams<{ companyPrefix?: string }>();
|
|
const location = RouterDom.useLocation();
|
|
|
|
if (params.companyPrefix) {
|
|
return normalizeCompanyPrefix(params.companyPrefix);
|
|
}
|
|
|
|
const pathPrefix = extractCompanyPrefixFromPath(location.pathname);
|
|
if (pathPrefix) return pathPrefix;
|
|
|
|
return selectedCompany ? normalizeCompanyPrefix(selectedCompany.issuePrefix) : null;
|
|
}
|
|
|
|
export * from "react-router-dom";
|
|
|
|
type CompanyLinkProps = React.ComponentProps<typeof RouterDom.Link> & {
|
|
disableIssueQuicklook?: boolean;
|
|
issuePrefetch?: Issue | null;
|
|
issueQuicklookSide?: React.ComponentProps<typeof IssueLinkQuicklook>["issueQuicklookSide"];
|
|
issueQuicklookAlign?: React.ComponentProps<typeof IssueLinkQuicklook>["issueQuicklookAlign"];
|
|
};
|
|
|
|
export const Link = React.forwardRef<HTMLAnchorElement, CompanyLinkProps>(
|
|
function CompanyLink({
|
|
to,
|
|
disableIssueQuicklook = false,
|
|
issuePrefetch = null,
|
|
issueQuicklookSide,
|
|
issueQuicklookAlign,
|
|
...props
|
|
}, ref) {
|
|
const companyPrefix = useActiveCompanyPrefix();
|
|
const resolvedTo = resolveTo(to, companyPrefix);
|
|
const issuePathId = parseIssuePathIdFromPath(typeof resolvedTo === "string" ? resolvedTo : resolvedTo.pathname);
|
|
|
|
if (issuePathId) {
|
|
return (
|
|
<IssueLinkQuicklook
|
|
ref={ref}
|
|
to={resolvedTo}
|
|
issuePathId={issuePathId}
|
|
disableIssueQuicklook={disableIssueQuicklook}
|
|
issuePrefetch={issuePrefetch}
|
|
issueQuicklookSide={issueQuicklookSide}
|
|
issueQuicklookAlign={issueQuicklookAlign}
|
|
{...props}
|
|
/>
|
|
);
|
|
}
|
|
|
|
return <RouterDom.Link ref={ref} to={resolvedTo} {...props} />;
|
|
},
|
|
);
|
|
|
|
export const NavLink = React.forwardRef<HTMLAnchorElement, React.ComponentProps<typeof RouterDom.NavLink>>(
|
|
function CompanyNavLink({ to, ...props }, ref) {
|
|
const companyPrefix = useActiveCompanyPrefix();
|
|
return <RouterDom.NavLink ref={ref} to={resolveTo(to, companyPrefix)} {...props} />;
|
|
},
|
|
);
|
|
|
|
export function Navigate({ to, ...props }: React.ComponentProps<typeof RouterDom.Navigate>) {
|
|
const companyPrefix = useActiveCompanyPrefix();
|
|
return <RouterDom.Navigate to={resolveTo(to, companyPrefix)} {...props} />;
|
|
}
|
|
|
|
export function useNavigate(): ReturnType<typeof RouterDom.useNavigate> {
|
|
const navigate = RouterDom.useNavigate();
|
|
const companyPrefix = useActiveCompanyPrefix();
|
|
|
|
return React.useCallback(
|
|
((to: To | number, options?: NavigateOptions) => {
|
|
if (typeof to === "number") {
|
|
navigate(to);
|
|
return;
|
|
}
|
|
navigate(resolveTo(to, companyPrefix), options);
|
|
}) as ReturnType<typeof RouterDom.useNavigate>,
|
|
[navigate, companyPrefix],
|
|
);
|
|
}
|